Fix tail -c OOM on large byte counts via stdin#24
Closed
kelp wants to merge 1 commit into
Closed
Conversation
processInputByBytesNoSeek pre-allocated byte_count bytes unconditionally, causing OOM for values like 10GB even on empty input. Cap the circular buffer at 64MB and fall back to a dynamic list that grows only with actual input data.
Owner
Author
|
Already merged. The 64MB MAX_CIRCULAR_BUFFER cap and processInputByBytesNoSeekDynamic fallback are on main, rewritten for 0.16 readers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tail -c 10000000000via stdin (pipes, /dev/null) caused OOM becauseprocessInputByBytesNoSeekpre-allocated the fullbyte_countas a circular bufferTest plan
zig build test --summary all-- all 1984 unit tests passjust it-util tail-- all 87 integration tests pass (0 failures)